Skip to content

Commit ddf5984

Browse files
committed
Allow subscribing to resources, but subscribe is only true if full set of handlers present.
1 parent 8c7d155 commit ddf5984

2 files changed

Lines changed: 8 additions & 7 deletions

File tree

src/ModelContextProtocol.Core/Server/McpServer.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,8 @@ await originalListResourceTemplatesHandler(request, cancellationToken).Configure
308308

309309
listChanged = true;
310310

311-
subscribe = true;
311+
// TODO: Implement subscribe/unsubscribe logic for resource and resource template collections
312+
// subscribe = true;
312313
}
313314

314315
ServerCapabilities.Resources.ListResourcesHandler = listResourcesHandler;

src/ModelContextProtocol/McpServerHandlers.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -185,13 +185,13 @@ internal void OverwriteWithSetHandlers(McpServerOptions options)
185185
resourcesCapability.ListResourceTemplatesHandler = ListResourceTemplatesHandler ?? resourcesCapability.ListResourceTemplatesHandler;
186186
resourcesCapability.ListResourcesHandler = ListResourcesHandler ?? resourcesCapability.ListResourcesHandler;
187187
resourcesCapability.ReadResourceHandler = ReadResourceHandler ?? resourcesCapability.ReadResourceHandler;
188+
}
188189

189-
if (SubscribeToResourcesHandler is not null || UnsubscribeFromResourcesHandler is not null)
190-
{
191-
resourcesCapability.SubscribeToResourcesHandler = SubscribeToResourcesHandler ?? resourcesCapability.SubscribeToResourcesHandler;
192-
resourcesCapability.UnsubscribeFromResourcesHandler = UnsubscribeFromResourcesHandler ?? resourcesCapability.UnsubscribeFromResourcesHandler;
193-
resourcesCapability.Subscribe = true;
194-
}
190+
if (SubscribeToResourcesHandler is not null || UnsubscribeFromResourcesHandler is not null)
191+
{
192+
resourcesCapability.SubscribeToResourcesHandler = SubscribeToResourcesHandler ?? resourcesCapability.SubscribeToResourcesHandler;
193+
resourcesCapability.UnsubscribeFromResourcesHandler = UnsubscribeFromResourcesHandler ?? resourcesCapability.UnsubscribeFromResourcesHandler;
194+
resourcesCapability.Subscribe = true;
195195
}
196196

197197
ToolsCapability? toolsCapability = options.Capabilities?.Tools;

0 commit comments

Comments
 (0)