Skip to content

Commit f0155d8

Browse files
ericstjCopilot
andcommitted
Remove diagnostic instrumentation
Remove all temporary diagnostic artifacts added during hang investigation: - Instrumented xUnit DLLs and ReplaceXunitWithInstrumented MSBuild targets - DiagnosticExceptionTracing.cs module initializer - DOTNET_RuntimeAsync=0 CI workaround (was wrong hypothesis) - xunit-runtest-diag.log artifact collection glob Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 37976fc commit f0155d8

6 files changed

Lines changed: 0 additions & 84 deletions

File tree

.github/workflows/ci-build-test.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,6 @@ jobs:
6161
run: make build CONFIGURATION=${{ matrix.configuration }}
6262

6363
- name: 🧪 Test
64-
# TODO: Remove DOTNET_RuntimeAsync=0 workaround once the .NET runtime fix is available.
65-
# Tracked by: https://github.com/dotnet/runtime/issues/126325
66-
# xUnit v3 test host hangs intermittently on .NET 10 with RuntimeAsync enabled.
67-
env:
68-
DOTNET_RuntimeAsync: "0"
6964
run: make test CONFIGURATION=${{ matrix.configuration }}
7065

7166
- name: 🧪 AOT Compatibility
@@ -86,7 +81,6 @@ jobs:
8681
name: testresults-${{ matrix.os }}-${{ matrix.configuration }}
8782
path: |
8883
artifacts/testresults/**
89-
**/xunit-runtest-diag.log
9084
9185
publish-coverage:
9286
if: github.actor != 'dependabot[bot]'
-175 KB
Binary file not shown.
-477 KB
Binary file not shown.

tests/Common/Utils/DiagnosticExceptionTracing.cs

Lines changed: 0 additions & 56 deletions
This file was deleted.

tests/ModelContextProtocol.AspNetCore.Tests/ModelContextProtocol.AspNetCore.Tests.csproj

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,4 @@
6262
<ProjectReference Include="..\ModelContextProtocol.ConformanceServer\ModelContextProtocol.ConformanceServer.csproj" />
6363
</ItemGroup>
6464

65-
<!-- TEMPORARY: Replace xUnit DLLs with instrumented versions that add tracing to
66-
TestRunner.RunTest to diagnose intermittent hang where finished TCS is never signaled.
67-
Remove this target once the root cause is identified. -->
68-
<Target Name="ReplaceXunitWithInstrumented" AfterTargets="Build"
69-
Condition="Exists('$(MSBuildThisFileDirectory)..\Common\InstrumentedXunit\xunit.v3.core.dll')">
70-
<Copy SourceFiles="$(MSBuildThisFileDirectory)..\Common\InstrumentedXunit\xunit.v3.core.dll"
71-
DestinationFolder="$(OutputPath)" OverwriteReadOnlyFiles="true" SkipUnchangedFiles="false" />
72-
<Copy SourceFiles="$(MSBuildThisFileDirectory)..\Common\InstrumentedXunit\xunit.v3.common.dll"
73-
DestinationFolder="$(OutputPath)" OverwriteReadOnlyFiles="true" SkipUnchangedFiles="false" />
74-
</Target>
75-
7665
</Project>

tests/ModelContextProtocol.Tests/ModelContextProtocol.Tests.csproj

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -98,15 +98,4 @@
9898
</Content>
9999
</ItemGroup>
100100

101-
<!-- TEMPORARY: Replace xUnit DLLs with instrumented versions that add tracing to
102-
TestRunner.RunTest to diagnose intermittent hang where finished TCS is never signaled.
103-
Remove this target once the root cause is identified. -->
104-
<Target Name="ReplaceXunitWithInstrumented" AfterTargets="Build"
105-
Condition="Exists('$(MSBuildThisFileDirectory)..\Common\InstrumentedXunit\xunit.v3.core.dll')">
106-
<Copy SourceFiles="$(MSBuildThisFileDirectory)..\Common\InstrumentedXunit\xunit.v3.core.dll"
107-
DestinationFolder="$(OutputPath)" OverwriteReadOnlyFiles="true" SkipUnchangedFiles="false" />
108-
<Copy SourceFiles="$(MSBuildThisFileDirectory)..\Common\InstrumentedXunit\xunit.v3.common.dll"
109-
DestinationFolder="$(OutputPath)" OverwriteReadOnlyFiles="true" SkipUnchangedFiles="false" />
110-
</Target>
111-
112101
</Project>

0 commit comments

Comments
 (0)