Configurable messages endpoint for SSE transport#109
Merged
stephentoub merged 1 commit intomodelcontextprotocol:mainfrom Mar 27, 2025
Merged
Conversation
halter73
approved these changes
Mar 26, 2025
Contributor
halter73
left a comment
There was a problem hiding this comment.
LGTM.
Long term, we'll probaby want to move this to an options type.
d1217c5
into
modelcontextprotocol:main
14 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a configurable value for messages endpoint in
SseResponseStreamTransport.Motivation and Context
The SseResponseStreamTransport has a hard-coded
/messagesendpoint but the MCP spec states that this should be set by the implementation.https://spec.modelcontextprotocol.io/specification/2024-11-05/basic/transports/
How Has This Been Tested?
This was tested in the sample application.
Breaking Changes
No
Types of changes
Checklist