Use different logger categories for client and server in McpJsonRpcEndpoint#110
Merged
stephentoub merged 2 commits intomodelcontextprotocol:mainfrom Mar 27, 2025
Merged
Conversation
stephentoub
reviewed
Mar 26, 2025
stephentoub
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing ModelContextProtocol.Server.McpClient logs in the AspNetCoreSseServer sample is weird. This would get even more confusing if the project actually did include the client.
I know we had a discussion about how it's better to take an ILoggerFactory than an ILogger in public APIs, and I still generally think that true. Fortunately, these APIs are not currently public.