Skip to content

Skip .NET Framework tests on non-Windows platforms #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 3 commits into from
Jan 30, 2026
Merged

Skip .NET Framework tests on non-Windows platforms #1226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
030b4bd
Initial plan
Copilot Jan 30, 2026
57de0aa
Skip .NET Framework tests on non-Windows platforms
Copilot Jan 30, 2026
6a2bb11
Consolidate test target frameworks into Directory.Build.props
Copilot Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/workflows/ci-build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,6 @@ jobs:
10.0.x
9.0.x

# NetFX testing on non-Windows requires mono
- name: 🔧 Setup Mono
if: runner.os == 'Linux'
run: sudo apt-get install -y mono-devel

- name: 🔧 Setup Mono on macOS
if: runner.os == 'macOS'
run: brew install mono

- name: 🔧 Set up Node.js
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
Expand Down
6 changes: 6 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,10 @@
<!-- Don't use x64 when running netfx test procs on Windows ARM -->
<PreferNativeArm64>true</PreferNativeArm64>
</PropertyGroup>

<PropertyGroup>
<!-- Shared target frameworks for test projects and test support projects. net472 is only included on Windows. -->
<DefaultTestTargetFrameworks>net10.0;net9.0;net8.0</DefaultTestTargetFrameworks>
<DefaultTestTargetFrameworks Condition="$([MSBuild]::IsOSPlatform('Windows'))">$(DefaultTestTargetFrameworks);net472</DefaultTestTargetFrameworks>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion samples/TestServerWithHosting/TestServerWithHosting.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFrameworks>net10.0;net9.0;net8.0;net472</TargetFrameworks>
<TargetFrameworks>$(DefaultTestTargetFrameworks)</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<PublishAot Condition="'$(TargetFramework)' == 'net9.0'">true</PublishAot>
Expand Down
2 changes: 1 addition & 1 deletion tests/ModelContextProtocol.TestServer/ModelContextProtocol.TestServer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFrameworks>net10.0;net9.0;net8.0;net472</TargetFrameworks>
<TargetFrameworks>$(DefaultTestTargetFrameworks)</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<AssemblyName>TestServer</AssemblyName>
Expand Down
2 changes: 1 addition & 1 deletion tests/ModelContextProtocol.Tests/ModelContextProtocol.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFrameworks>net10.0;net9.0;net8.0;net472</TargetFrameworks>
<TargetFrameworks>$(DefaultTestTargetFrameworks)</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

Expand Down