Skip to content

Add cross-platform netstandard2.0 test coverage #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
+4 −1
Open

Add cross-platform netstandard2.0 test coverage #1235

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f5ad652
Initial plan
Copilot Feb 2, 2026
38dcf26
Add netstandard2.0 test project targeting net8.0
Copilot Feb 2, 2026
eea465d
Add README for netstandard2.0 test project
Copilot Feb 2, 2026
753cc88
Use conditional SetTargetFramework in existing test project instead o…
Copilot Feb 2, 2026
db11c07
Remove platform-specific DefaultTestTargetFrameworks and apply SetTar…
Copilot Feb 2, 2026
259aee5
Revert "Remove platform-specific DefaultTestTargetFrameworks"
Copilot Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@
</PropertyGroup>

<PropertyGroup>
<!-- Shared target frameworks for test projects and test support projects. net472 is only included on Windows. -->
<!-- Shared target frameworks for test projects and test support projects. -->
<DefaultTestTargetFrameworks>net10.0;net9.0;net8.0</DefaultTestTargetFrameworks>
<DefaultTestTargetFrameworks Condition="$([MSBuild]::IsOSPlatform('Windows'))">$(DefaultTestTargetFrameworks);net472</DefaultTestTargetFrameworks>
Comment thread
eiriktsarpalis marked this conversation as resolved.
</PropertyGroup>
</Project>
5 changes: 4 additions & 1 deletion tests/ModelContextProtocol.Tests/ModelContextProtocol.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,10 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\src\ModelContextProtocol.Core\ModelContextProtocol.Core.csproj" />
<ProjectReference Include="..\..\src\ModelContextProtocol.Core\ModelContextProtocol.Core.csproj">
<!-- Force net8.0 tests to use netstandard2.0 build for netstandard2.0 test coverage on all platforms -->
<SetTargetFramework Condition="'$(TargetFramework)' == 'net8.0'">TargetFramework=netstandard2.0</SetTargetFramework>
</ProjectReference>
<ProjectReference Include="..\ModelContextProtocol.TestServer\ModelContextProtocol.TestServer.csproj" />
<ProjectReference Include="..\..\samples\TestServerWithHosting\TestServerWithHosting.csproj" />
</ItemGroup>
Expand Down