Skip to content

Fix stderr event loss due to missing WaitForExit in DisposeProcess #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 6 commits into from
Feb 15, 2026
+12 −0
Merged

Fix stderr event loss due to missing WaitForExit in DisposeProcess #1280

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
796d7d4
Initial plan
Copilot Feb 15, 2026
50263cf
Fix race condition in DisposeProcess that could skip flushing stderr …
Copilot Feb 15, 2026
0a6158f
Remove redundant HasExited check in DisposeProcess else branch
Copilot Feb 15, 2026
1a58fd5
Always call WaitForExit() (no args) before Dispose() in DisposeProcess
Copilot Feb 15, 2026
1826e6b
Guard WaitForExit() with HasExited check to avoid hanging if kill tim…
Copilot Feb 15, 2026
891c34c
Only call WaitForExit() when process exited on its own, not after Kil…
Copilot Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/ModelContextProtocol.Core/Client/StdioClientTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,11 @@ internal static void DisposeProcess(
// and Node.js does not kill its children when it exits properly.
process.KillTree(shutdownTimeout);
}

// Ensure all redirected stderr/stdout events have been dispatched
// before disposing. Only the no-arg WaitForExit() guarantees this;
// WaitForExit(int) (used by KillTree) does not.
process.WaitForExit();
Comment thread
stephentoub marked this conversation as resolved.
Outdated
}
finally
{
Expand Down
Loading