Remove McpServerConfig and have McpClientFactory accept IClientTransport instances directly.#230
Merged
eiriktsarpalis merged 5 commits intomodelcontextprotocol:mainfrom Apr 8, 2025
Conversation
eiriktsarpalis
commented
Apr 7, 2025
eiriktsarpalis
commented
Apr 7, 2025
stephentoub
reviewed
Apr 7, 2025
stephentoub
reviewed
Apr 7, 2025
stephentoub
reviewed
Apr 7, 2025
halter73
reviewed
Apr 7, 2025
Contributor
halter73
left a comment
halter73
left a comment
There was a problem hiding this comment.
I think this looks good aside from disposing the IClientTransport when ConnectAsync throws.
eiriktsarpalis
force-pushed
the
rework-client
branch
from
878a9d5 to
b2e290f
Compare
stephentoub
reviewed
Apr 8, 2025
stephentoub
reviewed
Apr 8, 2025
stephentoub
reviewed
Apr 8, 2025
stephentoub
reviewed
Apr 8, 2025
halter73
approved these changes
Apr 8, 2025
stephentoub
approved these changes
Apr 8, 2025
eiriktsarpalis
merged commit 3e21f35
into
modelcontextprotocol:main
13 of 15 checks passed
This was referenced Jul 24, 2025
jeffhandley
added
the
breaking-change
Contributor
|
Adding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Posting as draft to get early feedback on the direction being taken here.