Add server "completions" capability#232
Merged
stephentoub merged 2 commits intomodelcontextprotocol:mainfrom Apr 7, 2025
Merged
Add server "completions" capability#232stephentoub merged 2 commits intomodelcontextprotocol:mainfrom
stephentoub merged 2 commits intomodelcontextprotocol:mainfrom
Conversation
No code changes, just moving each type to its own file.
Contributor
There was a problem hiding this comment.
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/ModelContextProtocol/Server/McpServerHandlers.cs:46
- [nitpick] Consider updating the comment to avoid the repetitive phrase 'completion complete'. For example, change it to 'Gets or sets the handler for completion requests.'
/// Gets or sets the handler for completion complete requests.
halter73
approved these changes
Apr 7, 2025
Contributor
halter73
left a comment
halter73
left a comment
There was a problem hiding this comment.
I'm a big fan of splitting up Capabilities.cs
This was referenced Jul 24, 2025
jeffhandley
added
the
breaking-change
Contributor
|
Adding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest spec added a completions capability, subsuming the already existing completions/complete request method. This PR adds that capability type and moves/renames the existing handler to be exposed on that capability, as we've done with other capabilities.