Map enum properties as strings as specified

[yinzara]

Fixes #459

[stephentoub]

I don't think we want different behaviors here based on which build is being used.
cc: @eiriktsarpalis

[eiriktsarpalis]

Also, this doesn't address the issue at hand. UseStringEnumConverter tells the source generator to use the string-based converter for enums that it can see at compile time. It can't apply the same behavior to types introduced by the user since it can't be done in a AOT compatible manner.

[yinzara]

It was only introduced in .NET 8 I guess I can remove it if that’s the lowest sdk we support

…

On Wed, May 28, 2025 at 8:55 PM Stephen Toub ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/ModelContextProtocol/McpJsonUtilities.cs <#461 (comment)> : > @@ -78,7 +78,11 @@ internal static bool IsValidMcpToolSchema(JsonElement element) // Keep in sync with CreateDefaultOptions above. [JsonSourceGenerationOptions(JsonSerializerDefaults.Web, DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull, - NumberHandling = JsonNumberHandling.AllowReadingFromString)] + NumberHandling = JsonNumberHandling.AllowReadingFromString +#if NET9_0_OR_GREATER + ,UseStringEnumConverter = true I don't think we want different behaviors here based on which build is being used. cc: @eiriktsarpalis <https://github.com/eiriktsarpalis> — Reply to this email directly, view it on GitHub <#461 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFEA34KZM4RNYUOXXE26U33A2ALHAVCNFSM6AAAAAB6EJSAUKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNZWHE4DIMZZGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[eiriktsarpalis]

Superseded by #463. I'm going to close this, but thank you for the contribution regardless.