Convert records to classes#470
Merged
eiriktsarpalis merged 3 commits intomodelcontextprotocol:mainfrom May 30, 2025
Merged
Conversation
stephentoub
reviewed
May 30, 2025
stephentoub
approved these changes
May 30, 2025
jeffhandley
added
the
breaking-change
Contributor
|
This PR was identified as a breaking change during a retrospective audit of the v0.2.0-preview.3 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that we're somewhat inconsistent in our use of classes vs. records. In lieu of a good reason to use records (promoting
withexpressions in immutable types, need for structural equality comparison) this PR is changing all records to being regular classes for consistency and reduced IL size.