Skip to content

Add request options bag to high level requests and include Meta #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 14 commits into from
Dec 4, 2025
Merged

Add request options bag to high level requests and include Meta #970

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0d321f8
Add RequestOptions with meta to high-level client methods
mikekistler Nov 7, 2025
65b53f6
Little fixes for rebase to latest main
mikekistler Nov 27, 2025
5e00399
Add tests for meta in requests
mikekistler Nov 28, 2025
acf8e85
Another meta test
mikekistler Nov 28, 2025
80fbe01
Another meta test
mikekistler Nov 28, 2025
2b54bc8
Apply suggestions from code review
stephentoub Dec 2, 2025
03c724d
Address PR review comments
mikekistler Dec 3, 2025
cbc531f
Change McpClientTool.CallAsync to accept RequestOptions
mikekistler Dec 3, 2025
8bc7a06
Update src/ModelContextProtocol.Core/Client/McpClient.Methods.cs
mikekistler Dec 3, 2025
595b4b6
Address PR review feedback
mikekistler Dec 3, 2025
06af40e
Use _meta as backing field for both Meta and ProgressToken
mikekistler Dec 3, 2025
fccab7c
Add tests for RequestOptions and fix buggy Meta setter
mikekistler Dec 4, 2025
50fe47a
Merge branch 'main' into mdk/expose-meta
stephentoub Dec 4, 2025
5cf093f
Address my feedback
stephentoub Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/ModelContextProtocol.Core/RequestOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public JsonObject? Meta
}
set
{
// Preserve the progress token if set.
// Capture the existing progressToken value if set.
var progressToken = _meta?["progressToken"];
if (value is null)
{
Expand All @@ -52,7 +52,9 @@ public JsonObject? Meta
}
else
{
if (progressToken is not null) {
if (value["progressToken"] is null && progressToken is not null) {
// Remove existing progressToken so it can be set into the new meta.
_meta?.Remove("progressToken");
Comment thread
stephentoub marked this conversation as resolved.
Outdated
value["progressToken"] = progressToken;
Comment thread
stephentoub marked this conversation as resolved.
Outdated
}
_meta = value;
Expand Down Expand Up @@ -85,7 +87,6 @@ public ProgressToken? ProgressToken {
_meta ??= new JsonObject();
_meta["progressToken"] = token switch
{
null => _meta.Remove("progressToken"),
string s => s,
long l => l,
_ => throw new InvalidOperationException("ProgressToken must be a string or long"),
Expand Down
Loading