Commit 22205e6
authored
fix: bundle SDK+zod in react-with-deps (was byte-identical to ./react) (#539)
* chore: remove dead ./react-with-deps export (copy-paste bug from #221)
The react-with-deps build entry was introduced in PR #221 (e078250) as a
sibling to app-with-deps for CDN/unpkg no-bundler use. But its external
array was duplicated without editing — it never dropped @modelcontextprotocol/sdk
from externals, so it has shipped byte-identical to ./react for 10 releases
(v0.3.1 → v1.2.0).
After #534 merged, both entries use ['react', 'react-dom', ...PEER_EXTERNALS]
— still identical, just smaller.
Delete rather than fix: React apps always use a bundler; the CDN/unpkg
use case (HTML-string apps like qr-server) doesn't apply to React hooks.
Zero consumers verified (examples/docs/tests/plugins).
* fix: bundle SDK+zod in react-with-deps (keep React external)
Reverts the deletion from the previous commit and applies the actual fix.
The react-with-deps external array was copy-pasted in PR #221 without
dropping PEER_EXTERNALS — now it mirrors app-with-deps: bundles
@modelcontextprotocol/sdk + zod for CDN/import-map consumers.
React and react-dom MUST remain external — bundling them would cause
dual-React-instance hooks errors. Consumer provides them via import map.
Before: index.js 26KB == react-with-deps.js 26KB (identical MD5)
After: index.js 26KB != react-with-deps.js 323KB (SDK+zod bundled)1 parent a870456 commit 22205e6
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| |||
0 commit comments