chore(pdf-server): remove JSONL interaction logging

Remove the withLogging transport wrapper, logInteraction helper,
InteractionLogger type, and all log parameter threading that were
added for debugging.

Author: ochafik

examples/pdf-server/main.ts

@@ -10,11 +10,6 @@ import { StdioServerTransport } from "@modelcontextprotocol/sdk/server/stdio.js"
 import { createMcpExpressApp } from "@modelcontextprotocol/sdk/server/express.js";
 import type { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
 import { StreamableHTTPServerTransport } from "@modelcontextprotocol/sdk/server/streamableHttp.js";
-import type {
-  Transport,
-  TransportSendOptions,
-} from "@modelcontextprotocol/sdk/shared/transport.js";
-import type { JSONRPCMessage } from "@modelcontextprotocol/sdk/types.js";
 import cors from "cors";
 import type { Request, Response } from "express";
 import {
@@ -29,56 +24,6 @@ import {
   allowedLocalDirs,
 } from "./server.js";
 
-// =============================================================================
-// JSONL Interaction Logger
-// =============================================================================
-
-const LOG_PATH = path.join(import.meta.dirname, "interactions.jsonl");
-
-/** Append a JSONL line to the log file. */
-function logInteraction(entry: Record<string, unknown>): void {
-  const line = JSON.stringify({
-    timestamp: new Date().toISOString(),
-    ...entry,
-  });
-  fs.appendFile(LOG_PATH, line + "\n", (err) => {
-    if (err) console.error("[pdf-server] Failed to write log:", err.message);
-  });
-}
-
-/**
- * Wraps an MCP transport to log every incoming and outgoing JSON-RPC message
- * to a JSONL file at `interactions.jsonl` next to this script.
- */
-function withLogging<T extends Transport>(transport: T): T {
-  const originalSend = transport.send.bind(transport);
-
-  transport.send = async (
-    message: JSONRPCMessage,
-    options?: TransportSendOptions,
-  ): Promise<void> => {
-    logInteraction({ direction: "server→client", message });
-    return originalSend(message, options);
-  };
-
-  // Intercept the onmessage setter so we can log before the real handler runs
-  let realOnMessage = transport.onmessage;
-  Object.defineProperty(transport, "onmessage", {
-    get: () => realOnMessage,
-    set: (handler: typeof transport.onmessage) => {
-      realOnMessage = handler
-        ? (message, extra) => {
-            logInteraction({ direction: "client→server", message });
-            handler(message, extra);
-          }
-        : handler;
-    },
-    configurable: true,
-  });
-
-  return transport;
-}
-
 /**
  * Starts an MCP server with Streamable HTTP transport in stateless mode.
  */
@@ -92,11 +37,9 @@ export async function startStreamableHTTPServer(
 
   app.all("/mcp", async (req: Request, res: Response) => {
     const server = createServer();
-    const transport = withLogging(
-      new StreamableHTTPServerTransport({
-        sessionIdGenerator: undefined,
-      }),
-    );
+    const transport = new StreamableHTTPServerTransport({
+      sessionIdGenerator: undefined,
+    });
 
     res.on("close", () => {
       transport.close().catch(() => {});
@@ -143,7 +86,7 @@ export async function startStreamableHTTPServer(
 export async function startStdioServer(
   createServer: () => McpServer,
 ): Promise<void> {
-  await createServer().connect(withLogging(new StdioServerTransport()));
+  await createServer().connect(new StdioServerTransport());
 }
 
 function parseArgs(): { urls: string[]; stdio: boolean } {
@@ -195,15 +138,12 @@ async function main() {
     }
   }
 
-  console.error(
-    `[pdf-server] Ready (${urls.length} URL(s) configured, logging to ${LOG_PATH})`,
-  );
+  console.error(`[pdf-server] Ready (${urls.length} URL(s) configured)`);
 
-  const factory = () => createServer(logInteraction);
   if (stdio) {
-    await startStdioServer(factory);
+    await startStdioServer(createServer);
   } else {
-    await startStreamableHTTPServer(factory);
+    await startStreamableHTTPServer(createServer);
   }
 }
 

examples/pdf-server/server.ts

@@ -354,23 +354,15 @@ export function createPdfCache(): PdfCache {
 // MCP Roots
 // =============================================================================
 
-/** Optional structured logger for JSONL interaction logging. */
-export type InteractionLogger = (entry: Record<string, unknown>) => void;
-
 /**
  * Query the client for roots and update allowedLocalDirs with any file:// roots
  * that point to existing directories.
  */
-async function refreshRoots(
-  server: Server,
-  trigger: "initialized" | "roots/list_changed",
-  log?: InteractionLogger,
-): Promise<void> {
+async function refreshRoots(server: Server): Promise<void> {
   if (!server.getClientCapabilities()?.roots) return;
 
   try {
     const { roots } = await server.listRoots();
-    log?.({ event: "roots/list", trigger, roots });
     allowedLocalDirs.clear();
     for (const root of roots) {
       if (root.uri.startsWith("file://")) {
@@ -403,17 +395,17 @@ async function refreshRoots(
 // MCP Server Factory
 // =============================================================================
 
-export function createServer(log?: InteractionLogger): McpServer {
+export function createServer(): McpServer {
   const server = new McpServer({ name: "PDF Server", version: "2.0.0" });
 
   // Fetch roots on initialization and subscribe to changes
   server.server.oninitialized = () => {
-    refreshRoots(server.server, "initialized", log);
+    refreshRoots(server.server);
   };
   server.server.setNotificationHandler(
     RootsListChangedNotificationSchema,
     async () => {
-      await refreshRoots(server.server, "roots/list_changed", log);
+      await refreshRoots(server.server);
     },
   );