Skip to content

Commit 212988b

Browse files
committed
Impplemented separate silentLogger for browser usage where needed.
1 parent b318070 commit 212988b

5 files changed

Lines changed: 15 additions & 2 deletions

File tree

clients/web/src/components/AuthDebugger.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { useCallback, useEffect, useState } from "react";
22
import { Button } from "@/components/ui/button";
33
import { AlertCircle } from "lucide-react";
44
import type { InspectorClient } from "@modelcontextprotocol/inspector-core/mcp/index.js";
5-
import { silentLogger } from "@modelcontextprotocol/inspector-core/logging/node";
5+
import { silentLogger } from "@modelcontextprotocol/inspector-core/logging/browser";
66
import type { AuthGuidedState } from "@modelcontextprotocol/inspector-core/auth/types.js";
77
import type { WebEnvironmentResult } from "@/lib/adapters/environmentFactory";
88
import { OAuthFlowProgress } from "./OAuthFlowProgress";

clients/web/src/components/OAuthCallback.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { useCallback, useEffect, useRef, useState } from "react";
22
import type { InspectorClient } from "@modelcontextprotocol/inspector-core/mcp/index.js";
33
import type { WebEnvironmentResult } from "@/lib/adapters/environmentFactory";
44
import { parseOAuthState } from "@modelcontextprotocol/inspector-core/auth/index.js";
5-
import { silentLogger } from "@modelcontextprotocol/inspector-core/logging/node";
5+
import { silentLogger } from "@modelcontextprotocol/inspector-core/logging/browser";
66
import useTheme from "@/lib/hooks/useTheme";
77
import { useToast } from "@/lib/hooks/useToast";
88
import {

core/logging/browser/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export { silentLogger } from "./logger.js";

core/logging/browser/logger.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
/**
2+
* Silent logger for browser contexts. Satisfies pino.Logger; does not output anything.
3+
* Use when no logger is passed (e.g. OAuth callback with no client). Web components
4+
* that need a fallback import from logging/browser so they don't pull in Node logging.
5+
*/
6+
// @ts-expect-error - pino/browser.js exists but TypeScript doesn't have types for the .js extension
7+
import pino from "pino/browser.js";
8+
import type { Logger } from "pino";
9+
10+
export const silentLogger: Logger = pino({ level: "silent" });

core/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
"./mcp/node/*": "./build/mcp/node/*",
1919
"./auth/browser": "./build/auth/browser/index.js",
2020
"./auth/browser/*": "./build/auth/browser/*",
21+
"./logging/browser": "./build/logging/browser/index.js",
22+
"./logging/browser/*": "./build/logging/browser/*",
2123
"./logging/node": "./build/logging/node/index.js",
2224
"./logging/node/*": "./build/logging/node/*",
2325
"./mcp/remote": "./build/mcp/remote/index.js",

0 commit comments

Comments
 (0)