chore: added tests

Author: petereon

server/__tests__/args-parsing.test.ts

@@ -97,6 +97,47 @@ describe("/config endpoint: JSON array → shell-quoted string for client UI", (
     const parsed = shellParseArgs(result) as string[];
     expect(parsed).toEqual(["--message", 'say "hello"']);
   });
+
+  it("handles empty string element", () => {
+    const rawArgs = JSON.stringify(["--flag", ""]);
+    const result = processArgsForClient(rawArgs);
+    const parsed = shellParseArgs(result) as string[];
+    expect(parsed).toEqual(["--flag", ""]);
+  });
+
+  it("handles arg with newline", () => {
+    const rawArgs = JSON.stringify(["--msg", "line1\nline2"]);
+    const result = processArgsForClient(rawArgs);
+    const parsed = shellParseArgs(result) as string[];
+    expect(parsed).toEqual(["--msg", "line1\nline2"]);
+  });
+
+  it("handles arg with backslashes", () => {
+    const rawArgs = JSON.stringify(["--path", "C:\\Users\\foo"]);
+    const result = processArgsForClient(rawArgs);
+    const parsed = shellParseArgs(result) as string[];
+    expect(parsed).toEqual(["--path", "C:\\Users\\foo"]);
+  });
+
+  it("handles arg that looks like a JSON object", () => {
+    // e.g. --config '{"key":"val"}' — must not be mistaken for an outer JSON array
+    const rawArgs = JSON.stringify(["--config", '{"key":"val"}']);
+    const result = processArgsForClient(rawArgs);
+    const parsed = shellParseArgs(result) as string[];
+    expect(parsed).toEqual(["--config", '{"key":"val"}']);
+  });
+
+  it("handles arg that looks like a JSON array", () => {
+    const rawArgs = JSON.stringify(["--list", '["a","b"]']);
+    const result = processArgsForClient(rawArgs);
+    const parsed = shellParseArgs(result) as string[];
+    expect(parsed).toEqual(["--list", '["a","b"]']);
+  });
+
+  it("handles single-character flags", () => {
+    const rawArgs = JSON.stringify(["-v", "-x"]);
+    expect(processArgsForClient(rawArgs)).toBe("-v -x");
+  });
 });
 
 describe("createTransport: args string → parsed args array", () => {
@@ -122,6 +163,22 @@ describe("createTransport: args string → parsed args array", () => {
   it("handles empty string", () => {
     expect(parseArgsForTransport("")).toEqual([]);
   });
+
+  it("does not misinterpret a JSON-object arg as the outer container", () => {
+    // An arg value that is itself a JSON object should not be parsed as the array
+    const jsonArgs = JSON.stringify(["--config", '{"key":"val"}']);
+    const result = parseArgsForTransport(jsonArgs);
+    expect(result).toEqual(["--config", '{"key":"val"}']);
+  });
+
+  it("does not misinterpret a non-array JSON value as an args array", () => {
+    // If someone passes a plain JSON string (not an array), fall back to shellParseArgs
+    const notAnArray = '"just a string"';
+    const result = parseArgsForTransport(notAnArray);
+    // JSON.parse gives a string, not an array → falls back to shellParseArgs
+    // shellParseArgs on a quoted string returns the unquoted value
+    expect(result).toEqual(["just a string"]);
+  });
 });
 
 describe("full round-trip: start.js → /config → createTransport", () => {