test(network): use ListToggle aria-label in panel + modal tests

Cleanup spotted in PR review follow-up:

- HistoryListPanel + ServerSettingsModal previously fished the ListToggle
  out by empty text content because the toggle had no accessible name.
  Now that ListToggle exposes "Expand all" / "Collapse all", both tests
  can use getByRole + name and the stale comments go away.
- ListToggle's own tests now assert the aria-label contract so a future
  refactor can't silently drop it.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: cliffhall

clients/web/src/components/elements/ListToggle/ListToggle.test.tsx

@@ -4,23 +4,34 @@ import userEvent from "@testing-library/user-event";
 import { ListToggle } from "./ListToggle";
 
 describe("ListToggle", () => {
-  it("renders a Button by default", () => {
+  it("renders a Button by default with 'Expand all' aria-label when compact", () => {
     renderWithMantine(<ListToggle compact onToggle={() => {}} />);
-    expect(screen.getByRole("button")).toBeInTheDocument();
+    expect(
+      screen.getByRole("button", { name: "Expand all" }),
+    ).toBeInTheDocument();
   });
 
-  it("renders an ActionIcon for the subtle variant", () => {
+  it("renders 'Collapse all' aria-label when not compact", () => {
+    renderWithMantine(<ListToggle compact={false} onToggle={() => {}} />);
+    expect(
+      screen.getByRole("button", { name: "Collapse all" }),
+    ).toBeInTheDocument();
+  });
+
+  it("renders an ActionIcon for the subtle variant and labels it", () => {
     renderWithMantine(
       <ListToggle compact variant="subtle" onToggle={() => {}} />,
     );
-    expect(screen.getByRole("button")).toBeInTheDocument();
+    expect(
+      screen.getByRole("button", { name: "Expand all" }),
+    ).toBeInTheDocument();
   });
 
   it("invokes onToggle when clicked (default variant)", async () => {
     const user = userEvent.setup();
     const onToggle = vi.fn();
     renderWithMantine(<ListToggle compact onToggle={onToggle} />);
-    await user.click(screen.getByRole("button"));
+    await user.click(screen.getByRole("button", { name: "Expand all" }));
     expect(onToggle).toHaveBeenCalledTimes(1);
   });
 
@@ -30,7 +41,7 @@ describe("ListToggle", () => {
     renderWithMantine(
       <ListToggle compact={false} variant="subtle" onToggle={onToggle} />,
     );
-    await user.click(screen.getByRole("button"));
+    await user.click(screen.getByRole("button", { name: "Collapse all" }));
     expect(onToggle).toHaveBeenCalledTimes(1);
   });
 });

clients/web/src/components/groups/HistoryListPanel/HistoryListPanel.test.tsx

@@ -224,19 +224,13 @@ describe("HistoryListPanel", () => {
     renderWithMantine(
       <HistoryListPanel {...baseProps} entries={sampleEntries} />,
     );
-    // Initially expanded — Collapse buttons exist on each entry
+    // Initially expanded — Collapse buttons exist on each entry, and the
+    // ListToggle exposes its aria-label as "Collapse all".
     expect(
       screen.getAllByRole("button", { name: "Collapse" }).length,
     ).toBeGreaterThan(0);
 
-    // Find the ListToggle button (last subtle toolbar button at top — has no accessible name)
-    const buttons = screen.getAllByRole("button");
-    const toggle = buttons.find(
-      (b) =>
-        b.textContent === "" && b.classList.contains("mantine-Button-root"),
-    );
-    expect(toggle).toBeDefined();
-    await user.click(toggle!);
+    await user.click(screen.getByRole("button", { name: "Collapse all" }));
 
     // After toggle, entries collapsed — they show Expand
     expect(

clients/web/src/components/groups/ServerSettingsModal/ServerSettingsModal.test.tsx

@@ -246,16 +246,16 @@ describe("ServerSettingsModal", () => {
     expect(headersControl.getAttribute("aria-expanded")).toBe("true");
     expect(metadataControl.getAttribute("aria-expanded")).toBe("false");
 
-    // ListToggle is the first button in the header row; click to expand all.
-    const allButtons = screen.getAllByRole("button");
-    await user.click(allButtons[0]);
+    // Not every section is expanded → ListToggle starts in compact mode
+    // and exposes "Expand all" as its aria-label.
+    await user.click(screen.getByRole("button", { name: "Expand all" }));
 
     expect(metadataControl.getAttribute("aria-expanded")).toBe("true");
     expect(timeoutsControl.getAttribute("aria-expanded")).toBe("true");
     expect(oauthControl.getAttribute("aria-expanded")).toBe("true");
 
-    // Clicking again should collapse all.
-    await user.click(allButtons[0]);
+    // After expanding every section the toggle flips to "Collapse all".
+    await user.click(screen.getByRole("button", { name: "Collapse all" }));
     expect(headersControl.getAttribute("aria-expanded")).toBe("false");
     expect(metadataControl.getAttribute("aria-expanded")).toBe("false");
   });