Added linter to project, fixed all linter errors (~260). Should be no functional changes.

Author: BobDickinson

.github/workflows/main.yml

@@ -14,9 +14,6 @@ jobs:
     steps:
       - uses: actions/checkout@v6
 
-      - name: Check formatting
-        run: npx prettier --check .
-
       - uses: actions/setup-node@v6
         with:
           node-version-file: package.json
@@ -29,15 +26,14 @@ jobs:
       - name: Check version consistency
         run: npm run check-version
 
-      - name: Check linting
-        working-directory: ./web
+      - name: Lint
         run: npm run lint
 
-      - name: Run web tests
-        working-directory: ./web
-        run: npm test
+      - name: Build
+        run: npm run build
 
-      - run: npm run build
+      - name: Run tests
+        run: npm test
 
   publish:
     runs-on: ubuntu-latest

cli/__tests__/cli.test.ts

@@ -1,4 +1,4 @@
-import { describe, it, beforeAll, afterAll, expect } from "vitest";
+import { describe, it, expect } from "vitest";
 import { runCli } from "./helpers/cli-runner.js";
 import {
   expectCliSuccess,
@@ -37,7 +37,7 @@ describe("CLI Tests", () => {
       expect(Array.isArray(json.tools)).toBe(true);
 
       // Validate expected tools from test-mcp-server
-      const toolNames = json.tools.map((tool: any) => tool.name);
+      const toolNames = json.tools.map((tool: { name: string }) => tool.name);
       expect(toolNames).toContain("echo");
       expect(toolNames).toContain("get_sum");
       expect(toolNames).toContain("get_annotated_message");
@@ -381,7 +381,7 @@ describe("CLI Tests", () => {
       });
 
       try {
-        const port = await server.start();
+        await server.start();
         const result = await runCli([
           server.url,
           "--cli",
@@ -550,7 +550,6 @@ describe("CLI Tests", () => {
           "test-sse": {
             type: "sse",
             url: "http://localhost:3000/sse",
-            note: "Test SSE server",
           },
         },
       });
@@ -577,7 +576,6 @@ describe("CLI Tests", () => {
           "test-http": {
             type: "streamable-http",
             url: "http://localhost:3001/mcp",
-            note: "Test HTTP server",
           },
         },
       });

cli/__tests__/headers.test.ts

@@ -20,7 +20,7 @@ describe("Header Parsing and Validation", () => {
       });
 
       try {
-        const port = await server.start();
+        await server.start();
         const result = await runCli([
           server.url,
           "--cli",
@@ -58,7 +58,7 @@ describe("Header Parsing and Validation", () => {
       });
 
       try {
-        const port = await server.start();
+        await server.start();
         const result = await runCli([
           server.url,
           "--cli",
@@ -91,7 +91,7 @@ describe("Header Parsing and Validation", () => {
       });
 
       try {
-        const port = await server.start();
+        await server.start();
         const result = await runCli([
           server.url,
           "--cli",
@@ -123,7 +123,7 @@ describe("Header Parsing and Validation", () => {
       });
 
       try {
-        const port = await server.start();
+        await server.start();
         const result = await runCli([
           server.url,
           "--cli",

cli/__tests__/helpers/cli-runner.ts

@@ -54,11 +54,11 @@ export async function runCli(
             // On Unix, kill the process group
             process.kill(-child.pid!, "SIGTERM");
           }
-        } catch (e) {
+        } catch {
           // Process might already be dead, try direct kill
           try {
             child.kill("SIGKILL");
-          } catch (e2) {
+          } catch {
             // Process is definitely dead
           }
         }

cli/__tests__/helpers/fixtures.ts

@@ -3,6 +3,7 @@ import * as path from "path";
 import * as os from "os";
 import * as crypto from "crypto";
 import { getTestMcpServerCommand } from "@modelcontextprotocol/inspector-test-server";
+import type { MCPServerConfig } from "@modelcontextprotocol/inspector-core/mcp/index.js";
 
 /**
  * Sentinel value for tests that don't need a real server
@@ -54,7 +55,7 @@ function createTempDir(prefix: string = "mcp-inspector-test-"): string {
 function cleanupTempDir(dir: string) {
   try {
     fs.rmSync(dir, { recursive: true, force: true });
-  } catch (err) {
+  } catch {
     // Ignore cleanup errors
   }
 }
@@ -63,7 +64,7 @@ function cleanupTempDir(dir: string) {
  * Create a test config file
  */
 export function createTestConfig(config: {
-  mcpServers: Record<string, any>;
+  mcpServers: Record<string, MCPServerConfig>;
 }): string {
   const tempDir = createTempDir("mcp-inspector-config-");
   const configPath = path.join(tempDir, "config.json");

cli/__tests__/tools.test.ts

@@ -29,7 +29,7 @@ describe("Tool Tests", () => {
       expect(json.tools[0]).toHaveProperty("name");
       expect(json.tools[0]).toHaveProperty("description");
       // Validate expected tools from test-mcp-server
-      const toolNames = json.tools.map((tool: any) => tool.name);
+      const toolNames = json.tools.map((tool: { name: string }) => tool.name);
       expect(toolNames).toContain("echo");
       expect(toolNames).toContain("get_sum");
       expect(toolNames).toContain("get_annotated_message");
@@ -133,7 +133,9 @@ describe("Tool Tests", () => {
       expect(Array.isArray(json.content)).toBe(true);
       // Should have both text and image content
       expect(json.content.length).toBeGreaterThan(1);
-      const hasImage = json.content.some((item: any) => item.type === "image");
+      const hasImage = json.content.some(
+        (item: { type?: string }) => item.type === "image",
+      );
       expect(hasImage).toBe(true);
     });
 
@@ -157,7 +159,9 @@ describe("Tool Tests", () => {
       expect(json).toHaveProperty("content");
       expect(Array.isArray(json.content)).toBe(true);
       // Should only have text content, no image
-      const hasImage = json.content.some((item: any) => item.type === "image");
+      const hasImage = json.content.some(
+        (item: { type?: string }) => item.type === "image",
+      );
       expect(hasImage).toBe(false);
       // test-mcp-server returns "This is a {messageType} message"
       expect(json.content[0].text.toLowerCase()).toContain("error");

cli/package.json

@@ -17,6 +17,7 @@
   "scripts": {
     "build": "tsc",
     "postbuild": "node scripts/make-executable.js",
+    "lint": "prettier --check . && eslint . --max-warnings 0 && echo 'Lint passed.'",
     "test": "vitest run",
     "test:watch": "vitest",
     "test:cli": "vitest run cli.test.ts",

cli/src/cli.ts

@@ -69,10 +69,6 @@ function handleError(error: unknown): never {
   process.exit(1);
 }
 
-function delay(ms: number): Promise<void> {
-  return new Promise((resolve) => setTimeout(resolve, ms, true));
-}
-
 async function runWeb(args: Args): Promise<void> {
   // Path to the web entry point
   const inspectorWebPath = resolve(

cli/src/index.ts

@@ -164,11 +164,13 @@ async function callMethod(args: Args): Promise<void> {
   // Read package.json to get name and version for client identity
   const pathA = "../package.json"; // We're in package @modelcontextprotocol/inspector-cli
   const pathB = "../../package.json"; // We're in package @modelcontextprotocol/inspector
-  let packageJson: { name: string; version: string };
-  let packageJsonData = await import(fs.existsSync(pathA) ? pathA : pathB, {
+  const packageJsonData = await import(fs.existsSync(pathA) ? pathA : pathB, {
     with: { type: "json" },
   });
-  packageJson = packageJsonData.default;
+  const packageJson = packageJsonData.default as {
+    name: string;
+    version: string;
+  };
 
   const [, name = packageJson.name] = packageJson.name.split("/");
   const version = packageJson.version;
@@ -285,11 +287,7 @@ async function callMethod(args: Args): Promise<void> {
 
     await awaitableLog(JSON.stringify(result, null, 2));
   } finally {
-    try {
-      await inspectorClient.disconnect();
-    } catch (disconnectError) {
-      throw disconnectError;
-    }
+    await inspectorClient.disconnect();
   }
 }
 
@@ -458,7 +456,7 @@ function parseArgs(): Args {
     toolMetadata?: Record<string, JsonValue>;
   };
 
-  let remainingArgs = program.args;
+  const remainingArgs = program.args;
 
   // Add back any arguments that came after --
   const finalArgs = [...remainingArgs, ...postArgs];

core/__tests__/auth/providers.test.ts

@@ -37,18 +37,19 @@ describe("OAuthNavigation", () => {
 
   describe("BrowserNavigation", () => {
     // Mock window.location for Node.js environment
-    const originalWindow = global.window;
+    type GlobalWithWindow = typeof globalThis & {
+      window?: { location: { href: string } };
+    };
+    const originalWindow = (global as GlobalWithWindow).window;
 
     beforeEach(() => {
-      (global as any).window = {
-        location: {
-          href: "http://localhost:5173",
-        },
-      };
+      (global as GlobalWithWindow).window = {
+        location: { href: "http://localhost:5173" },
+      } as GlobalWithWindow["window"];
     });
 
     afterEach(() => {
-      global.window = originalWindow;
+      (global as GlobalWithWindow).window = originalWindow;
     });
 
     it("should set window.location.href to authorization URL", () => {
@@ -57,11 +58,14 @@ describe("OAuthNavigation", () => {
 
       navigation.navigateToAuthorization(authUrl);
 
-      expect((global as any).window.location.href).toBe(authUrl.toString());
+      expect((global as GlobalWithWindow).window!.location.href).toBe(
+        authUrl.toString(),
+      );
     });
 
     it("should throw error in non-browser environment", () => {
-      delete (global as any).window;
+      (global as GlobalWithWindow).window =
+        undefined as unknown as GlobalWithWindow["window"];
       const navigation = new BrowserNavigation();
       const authUrl = new URL("http://example.com/authorize");