Skip to content

fix: call tasks/result when task status is input_required #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
galagaevdc wants to merge 1 commit into
base: main
Choose a base branch
from
+378 −13
Open

fix: call tasks/result when task status is input_required #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 42 additions & 13 deletions client/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,21 +1148,50 @@ const App = () => {
? ((response as { _meta?: Record<string, unknown> })._meta ??
{})
: undefined;
latestToolResult = {
content: [

if (taskStatus.status === "input_required") {
// Per MCP spec: when input_required, call tasks/result to give
// the server a chance to deliver queued elicitation/sampling
// requests. After elicitation is handled, the task transitions
// back to "working" — do NOT set taskCompleted here.
latestToolResult = {
content: [
{
type: "text",
text: `Task status: input_required${taskStatus.statusMessage ? ` - ${taskStatus.statusMessage}` : ""}. Awaiting input...`,
},
],
_meta: {
...(pollingResponseMeta || {}),
"io.modelcontextprotocol/related-task": { taskId },
},
};
setToolResult(latestToolResult);
await sendMCPRequest(
{
type: "text",
text: `Task status: ${taskStatus.status}${taskStatus.statusMessage ? ` - ${taskStatus.statusMessage}` : ""}. Polling...`,
method: "tasks/result",
params: { taskId },
},
],
_meta: {
...(pollingResponseMeta || {}),
"io.modelcontextprotocol/related-task": { taskId },
},
};
setToolResult(latestToolResult);
// Refresh tasks list to show progress
void listTasks();
CompatibilityCallToolResultSchema,
);
void listTasks();
} else {
latestToolResult = {
content: [
{
type: "text",
text: `Task status: ${taskStatus.status}${taskStatus.statusMessage ? ` - ${taskStatus.statusMessage}` : ""}. Polling...`,
},
],
_meta: {
...(pollingResponseMeta || {}),
"io.modelcontextprotocol/related-task": { taskId },
},
};
setToolResult(latestToolResult);
// Refresh tasks list to show progress
void listTasks();
}
}
} catch (pollingError) {
console.error("Error polling task status:", pollingError);
Expand Down
Loading