feat(sort): add SortToggle for Logs, History, and Network (#1371)#1372
Open
cliffhall wants to merge 2 commits into
Open
feat(sort): add SortToggle for Logs, History, and Network (#1371)#1372cliffhall wants to merge 2 commits into
cliffhall wants to merge 2 commits into
Conversation
Introduces a reusable SortToggle element and wires it into the Logs, History, and Network screens so users can flip chronological order. Selection is persisted per-screen to localStorage under the inspector.sortDirection.* namespace, with invalid stored values falling back to the newest-first default. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SortToggleelement (MantineSelectwith "Sort: Newest First" / "Sort: Oldest First").localStorageunderinspector.sortDirection.{logs,history,network}via@mantine/hooksuseLocalStorage. Invalid stored values fall back to thenewest-firstdefault so the toggle never renders in an unselectable state.localStorageshim in the unit-test setup because Node 22+ exposes an experimental placeholder that masks happy-dom's implementation when--localstorage-fileis not provided.Closes #1371.
Test plan
npm run validate(format, lint, build, unit tests + coverage)npm run test:storybook(323 stories pass under headless Chromium)inspector.sortDirection.logsin DevTools and confirm fallback to "Sort: Newest First"🤖 Generated with Claude Code