feat: Show initialize request/response in History panel (#269)#270
Merged
cliffhall merged 1 commit intoApr 15, 2025
Conversation
leoshimo
force-pushed
the
leo/269-show-initialize-request-in-history
branch
from
1599a7b to
f43b68d
Compare
pulkitsharma07
approved these changes
Apr 5, 2025
cliffhall
requested changes
Apr 11, 2025
Member
cliffhall
left a comment
cliffhall
left a comment
There was a problem hiding this comment.
Love this, just one little change...
cliffhall
added
enhancement
leoshimo
force-pushed
the
leo/269-show-initialize-request-in-history
branch
from
f43b68d to
58f2e0d
Compare
cliffhall
previously approved these changes
Apr 14, 2025
Member
cliffhall
left a comment
cliffhall
left a comment
There was a problem hiding this comment.
Code, build, test, lint all good. Tested locally, LGTM! 👍
Contributor
Author
|
Thank you @cliffhall! |
Member
|
@leoshimo I tested your branch locally and tests run just fine. But on here, the |
Contributor
Author
I'll take a look this evening 👍 |
leoshimo
force-pushed
the
leo/269-show-initialize-request-in-history
branch
2 times, most recently
from
58f2e0d to
bbca441
Compare
…protocol#269) - Add logging for initialize request and response in useConnection.connect - Include server capabilities, version, and instructions in history
leoshimo
force-pushed
the
leo/269-show-initialize-request-in-history
branch
from
bbca441 to
22eb813
Compare
Contributor
Author
|
Updated! cc @cliffhall |
IgnacioC44
referenced
this pull request
in MCPJam/inspector
Jun 21, 2025
…-in-history feat: Show initialize request/response in History panel (#269)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a candidate PR for issue #269.
Fixes #269
This PR adds a representation of initialize request and response to the History panel.
Motivation and Context
The information in server's
initializeresponse is very helpful - notablyinstructionsandserverCapabilities. It would be great to see it in the inspector.How Has This Been Tested?
Tested connecting with variety of servers -
server-everything,linear-mcp-serverBreaking Changes
No
Types of changes
Checklist
Additional Context
I am using the existing
pushHistorymethod to push the request / response forinitializeRPC messages.There's a rub: the actual RPC request is abstracted in
Client.connect(includingnotification/initialized).This means that the payload pushed to history can potentially diverge from the one in the API client. I took the conservative approach, by representing the request with
methodonly - I think the key information is the server response.