Enable Authentication header name configuration#272
Conversation
|
@pulkitsharma07 fixed comments and added tests :) |
Hi @idosal Can you add a video (or loom if it's too long) of using an alternative header and an easy set of steps to reproduce? |
Hey @cliffhall , |
Seems like a worthwhile change if there are places out there that do this. Maybe you'd like to find a site that uses something other than "Authorization" header? I wouldn't want to merge without testability. |
That makes complete sense. I'm afraid I couldn't find a good example in the wild. Attaching a screenshot that shows the custom header being added to the request instead of If you feel the feature should wait until there are live examples, that's perfectly understandable. |
|
@pulkitsharma07 @cliffhall I've pushed all requested changes. |
Co-authored-by: Ola Hungerford <olahungerford@gmail.com>
cliffhall
left a comment
There was a problem hiding this comment.
Weird. My review page was out of sync and it looked as if the README wasn't amended. LGTM! 👍
Enable Authentication header name configuration

This change adds a Header Name field to the sidebar. It overrides the "Authorization" default name.
Motivation and Context
Some servers use a custom header name (e.g., Vercel Preview). The current feature doesn't support these servers.
How Has This Been Tested?
I've added unit tests and tested it manually
Breaking Changes
No breaking changes.
Types of changes
Checklist
Additional context
Please let me know if it requires any changes, and thanks for the great project!