Skip to content

fix: missing condition for lengthy strings#300

Merged
cliffhall merged 3 commits into
modelcontextprotocol:mainfrom
kavinkumar807:fix-tool-error-is-not-highlighted-for-sample-llm-tool-call-rejection
Apr 14, 2025
Merged

fix: missing condition for lengthy strings#300
cliffhall merged 3 commits into
modelcontextprotocol:mainfrom
kavinkumar807:fix-tool-error-is-not-highlighted-for-sample-llm-tool-call-rejection

Conversation

@kavinkumar807
Copy link
Copy Markdown
Contributor

Tool error not highlighted for lengthy strings. This PR fixes #299

Motivation and Context

When I was testing the sample LLM tool found that the tool error not being highlighted due to the missing condition in the lengthy strings.

Screenshot 2025-04-12 at 5 52 15 PM

How Has This Been Tested?

  • Tested the sample LLM tool call and made sure the error is highlighted
  • Tested the normal tool calls flow with server-everything

Breaking Changes

There are no breaking changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

This is bug is related to the enhancement #275

@kavinkumar807
Copy link
Copy Markdown
Contributor Author

kavinkumar807 commented Apr 14, 2025

@olaservo @cliffhall synced the PR

Copy link
Copy Markdown
Member

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the title of the PR being confusing, the branch name tells the story and the code change was simple. Tested locally and verified the bug and the fix.

Screenshot 2025-04-14 at 5 42 08 PM Screenshot 2025-04-14 at 5 47 08 PM

@cliffhall cliffhall merged commit 25cc0f6 into modelcontextprotocol:main Apr 14, 2025
2 checks passed
IgnacioC44 referenced this pull request in MCPJam/inspector Jun 21, 2025
…lighted-for-sample-llm-tool-call-rejection

fix: missing condition for lengthy strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool error is not highlighted for sample LLM tool call rejection

3 participants