Fix: Store auth tokens with server-specific keys#317
Merged
cliffhall merged 2 commits intoApr 16, 2025
Merged
Conversation
Changes client information and access tokens to use server-specific keys in sessionStorage. This fixes issues where changing the server URL would try to use tokens from a different server.
cliffhall
approved these changes
Apr 16, 2025
Member
|
Thanks for this @geelen! |
IgnacioC44
referenced
this pull request
in MCPJam/inspector
Jun 21, 2025
Fix: Store auth tokens with server-specific keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds server-specific storage for auth tokens and client information in sessionStorage.
Problem
When changing the server URL in the sidebar, the inspector would try to reuse any client information or auth tokens that it had stored in
sessionStorage, but they wouldn't make any sense to the new server. This was driving me crazy as I kept thinking there was a flake on the server side or in our library: https://github.com/cloudflare/workers-oauth-provider)Fix
InspectorOAuthClientProviderto require a server URL as a constructor parameterThis ensures that tokens and client information are properly isolated between different servers:
This should be a lot more reliable now.