Skip to content

fix: console warning in sidebar#320

Merged
olaservo merged 2 commits into
modelcontextprotocol:mainfrom
kavinkumar807:fix-sidebar-console-warning
Apr 16, 2025
Merged

fix: console warning in sidebar#320
olaservo merged 2 commits into
modelcontextprotocol:mainfrom
kavinkumar807:fix-sidebar-console-warning

Conversation

@kavinkumar807
Copy link
Copy Markdown
Contributor

@kavinkumar807 kavinkumar807 commented Apr 16, 2025

This PR fixes the console warning in sidebar in logging level select element. Added key attribute in the select element to fix this

Screenshot 2025-04-14 at 11 41 46 PM

Motivation and Context

This solves the console warning associated with the sidebar logging level select element.

How Has This Been Tested?

Tested in the browser console

Screenshot 2025-04-16 at 12 00 32 PM

Breaking Changes

There are no breaking changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

- added key in select item to fix the console warning
@kavinkumar807
Copy link
Copy Markdown
Contributor Author

@cliffhall Added PR to fix the console warning

@olaservo olaservo added the bug Something isn't working label Apr 16, 2025
Copy link
Copy Markdown
Member

@olaservo olaservo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@olaservo olaservo merged commit befa209 into modelcontextprotocol:main Apr 16, 2025
2 checks passed
@cliffhall
Copy link
Copy Markdown
Member

Good catch @kavinkumar807!

IgnacioC44 referenced this pull request in MCPJam/inspector Jun 21, 2025
fix: add key prop to fix console warning in sidebar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants