Run the CLI tests in CI#621
Merged
Merged
Conversation
leblancfg
commented
Jul 14, 2025
Right now, the inspector has a CLI feature as well as a series of tests. However, they're not currently run in CI. For the moment, they are only triggered on file changes in the CLI folder, as AFAICT it is currently a separate code base.
This commit is mostly so that we can see whether the CI triggers a check of the CLI tests when files are touched within the CLI folder.
olaservo
previously requested changes
Jul 15, 2025
Member
olaservo
left a comment
olaservo
left a comment
There was a problem hiding this comment.
Thanks for adding this! Looks like it just needs a formatting fix:
[warn] .github/workflows/cli_tests.yml
[warn] Code style issues found in the above file. Run Prettier with --write to fix.
Contributor
Author
|
Ah test failure in CI, sorry lemme fix that |
Contributor
Author
|
Jesus H Christ! Haha finally made it work 😓 @olaservo ready for review 🙇🏻 |
cliffhall
requested changes
Jul 15, 2025
Member
cliffhall
left a comment
cliffhall
left a comment
There was a problem hiding this comment.
CLI tests running successfully in CI. Changes look good.
cliffhall
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, the inspector has a CLI feature as well as a series of tests. However, they're not currently run in CI. For the moment, they are only triggered on file changes in the CLI folder, as AFAICT it is currently a separate code base.
Motivation and Context
I pushed up a PR that touches files in the CLI folder (#595) and had to manually show the test run results.
How Has This Been Tested?
The check itself within the GitHub UI should be sufficient.
Breaking Changes
N/A
Types of changes
Checklist