Parse tool args from CLI as JsonValue instead of just strings#647
Merged
Conversation
cliffhall
requested changes
Aug 22, 2025
Member
cliffhall
left a comment
There was a problem hiding this comment.
Tested locally, looks good. I wonder if we should add an example of JSON tool args in the CLI Mode section of the README?
Member
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CLI argument parsing to support JSON values (resolves #431)
Motivation and Context
The CLI only accepted string arguments for tool calls, while the web UI supported full JSON values (objects, arrays, numbers, booleans). This made the CLI less useful for testing tools that require structured data.
How Has This Been Tested?
Breaking Changes
None. All existing CLI usage continues to work unchanged.
Types of changes
Checklist