Align Quick OAuth Flow and Simple Connect Flow with Guided OAuth Flow behavior#722
Merged
cliffhall merged 6 commits intoAug 18, 2025
Merged
Conversation
- In oauth-state-machine.ts
- in token_request transition
- ensure resource is URL type, not string
- this fixes Quick flow which was sending string, while guided was using proper URL type and working
…cluded in client metadata when client is registered.
- In auth.ts
- in InspectorOAuthClientProvider constructor
- add optional scope param
- set instance var this.scope to scope param
- in clientMetadata getter
- add scope param set to this.scope or ""
- in useConnection.ts
- in handleAuthError handler
- move instantiation of serverAuthProvider until after scope has been determined
- pass scope to InspectorOAuthClientProvider constructor
olaservo
previously approved these changes
Aug 18, 2025
olaservo
left a comment
Member
There was a problem hiding this comment.
Looks good to me 👍
Should we also bump SDK from 1.17.2 to 1.17.3 ? Doesn't look like there is anything directly related, but might as well?
olaservo
approved these changes
Aug 18, 2025
This was referenced Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Error: invalid_scope. Details: Client was not registered with scope mcp:tools. This change makes sure that scope is included in client metadata when client is registered.How Has This Been Tested?
In the Typescript SDK there is an example server that can be started in oauth mode, which allows us to test this flow.
tsx --watch src/examples/server/simpleStreamableHttp.ts --oauthGuided Flow
guided.mov
Quick Flow
Quick.mov
Simple Connect Flow
Connect.mov
Breaking Changes
Nope.
Types of changes
Checklist
Additional context