Update mcp functions to use ServerSSESession with lambda receiver#180
Closed
Update mcp functions to use ServerSSESession with lambda receiver#180
mcp functions to use ServerSSESession with lambda receiver#180Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MCP (Model Context Protocol) server functions to provide ServerSSESession as a context receiver instead of using a simple lambda. This change allows the lambda functions to access ServerSSESession properties and methods directly within their scope.
Key changes:
- Updated function signatures to use
ServerSSESession.() -> Serverinstead of() -> Server - Applied changes to all
mcp()functions and the deprecatedMCP()function - Updated the internal
mcpSseEndpointfunction parameter accordingly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| KtorServer.kt | Updated all mcp function signatures to use ServerSSESession as context receiver |
| kotlin-sdk.api | Updated API signatures from Function0 to Function1 to reflect the context receiver change |
Comments suppressed due to low confidence (1)
src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/KtorServer.kt:74
- The function call
block()is incorrect. Since the block parameter now has a ServerSSESession receiver, it should be called asblock(this)orthis.block()to provide the ServerSSESession context.
val server = block()
9 tasks
Contributor
Author
|
duplicated by #190 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide
ServeSSESessionas a context receiver.Motivation and Context
How Has This Been Tested?
locally
Breaking Changes
Yes, changed signature for
mcpserver extensionsTypes of changes
Checklist