use SSEClientExcpetion instead of ClientRequestException#207
Merged
devcrocod merged 2 commits intomodelcontextprotocol:mainfrom Aug 7, 2025
Merged
use SSEClientExcpetion instead of ClientRequestException#207devcrocod merged 2 commits intomodelcontextprotocol:mainfrom
devcrocod merged 2 commits intomodelcontextprotocol:mainfrom
Conversation
shiqicao
changed the title
shiqicao
force-pushed
the
sse_client_exception
branch
from
20472f7 to
7929ff3
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an exception handling issue in the StreamableHttpClientTransport class by catching the correct exception type. The code was incorrectly catching ClientRequestException when it should catch SSEClientException, which is the actual exception thrown by the SSE client session.
devcrocod
previously approved these changes
Aug 6, 2025
Contributor
devcrocod
left a comment
devcrocod
left a comment
There was a problem hiding this comment.
lgtm
Please fix the code formatting, run ./gradlew ktlintFormat
devcrocod
force-pushed
the
sse_client_exception
branch
from
3f85a4c to
2c8dc24
Compare
devcrocod
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client.sseSessiondoesn't throwClientRequestException, it throwsSSEClientExceptionMotivation and Context
Without this fix,
StreamableHTTPTransportcrashes for stateless requestHow Has This Been Tested?
Manually tested
Breaking Changes
No
Types of changes
Checklist
Additional context