Add recovery during deserialization and upload test artifacts#243
Merged
tiginamaria merged 2 commits intomodelcontextprotocol:mainfrom Aug 29, 2025
skarpovdev:skarpov/fix-readbuffer
Merged
Add recovery during deserialization and upload test artifacts#243tiginamaria merged 2 commits intomodelcontextprotocol:mainfrom skarpovdev:skarpov/fix-readbuffer
tiginamaria merged 2 commits intomodelcontextprotocol:mainfrom
skarpovdev:skarpov/fix-readbuffer
Conversation
…it Platform for JVM tests
9 tasks
…use JUnit Platform for JVM tests
tiginamaria
approved these changes
Aug 29, 2025
Contributor
tiginamaria
left a comment
There was a problem hiding this comment.
Thank you! I've left just one clarification question there to know the exact reason of the parsing error. Other than that, all is good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Now
should ignore first output messagestest fails because the valid JSON message is on the same line as non-JSON "Stdio server started".I added a recovery which attempts to find JSON by searching for the first
{. A case when we fail to desirialize a string remains the same and logs the error message as before. It is generallt not a likely case since it is expected that each message is on a separate line, but it doesn't seem to cost us anything to try and recover an otherwise lost valid message from the server.The changes in kotlin-sdk-test/build.gradle.kts are necessary because without them the JVM tests that use JUnit5 are not run at the moment.
The changes in .github/workflows/validate-pr.yml will allow us to view test results as artifacts to see which tests were skipped and generally simplify investigating tests results.
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context