#302 Update samples build workflow#330
Conversation
EugeneTheDev
left a comment
EugeneTheDev
left a comment
There was a problem hiding this comment.
Generally looks good to me, only minor comments
| } | ||
| plugins { | ||
| // Apply the foojay-resolver plugin to allow automatic download of JDKs | ||
| id("org.gradle.toolchains.foojay-resolver-convention") version "1.0.0" |
There was a problem hiding this comment.
Same, let's move to libs.versions.toml
devcrocod
left a comment
devcrocod
left a comment
There was a problem hiding this comment.
I have a few questions, could you please take a look at them?
| koverLog koverHtmlReport \ | ||
| publishToMavenLocal | ||
| publishToMavenLocal \ | ||
| -Pversion=0.0.1-SNAPSHOT |
There was a problem hiding this comment.
Why is this version being used? Shouldn’t we use the latest version + snapshot instead?
There was a problem hiding this comment.
No, it would be harder to maintain. This is an ephemeral version for the build process only.
There was a problem hiding this comment.
Do we need a separate toml file for each example?
Maybe it would be clearer to specify the versions directly in the build.gradle files instead?
Also, we should check the dependabot workflow to make sure it monitors these files as well
There was a problem hiding this comment.
Yes, samples should be completely independent from SDK
3 participants
#302 Update samples build workflow
Motivation and Context
Samples should be independently buildable
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context