Increase deprecation levels#393
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR advances the deprecation cycle by increasing the deprecation level for SSE transport type aliases from WARNING to ERROR, removing a fully deprecated function, and updating sample code to use the new API.
- Increased deprecation level for
SSEClientTransportandSSEServerTransporttype aliases from WARNING to ERROR - Removed the deprecated
MCPfunction that had already reached ERROR deprecation level - Updated sample code to use
createSessioninstead of the deprecatedconnectmethod
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| kotlin-sdk-client/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/client/SSEClientTransport.kt | Increased deprecation level to ERROR for SSEClientTransport type alias |
| kotlin-sdk-server/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/SSEServerTransport.kt | Increased deprecation level to ERROR for SSEServerTransport type alias |
| kotlin-sdk-server/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/KtorServer.kt | Removed deprecated MCP function |
| kotlin-sdk-server/api/kotlin-sdk-server.api | Updated API signature file to reflect removal of MCP function |
| samples/weather-stdio-server/src/main/kotlin/io/modelcontextprotocol/sample/server/McpWeatherServer.kt | Updated to use createSession instead of connect |
| samples/kotlin-mcp-server/src/main/kotlin/io/modelcontextprotocol/sample/server/server.kt | Updated to use createSession instead of connect in both SSE and stdio examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSEClientTransportandSSEServerTransportfromwarningtoerrorMCPcreateSessioninstead of deprecated oneMotivation and Context
cleanup code and deprecation cycle
Breaking Changes
None
Types of changes
Checklist