Skip to content

fix(ci): add node setup in release workflow#684

Merged
devcrocod merged 3 commits intomainfrom
devcrocod/release-workflow-node-setup
Apr 13, 2026
Merged

fix(ci): add node setup in release workflow#684
devcrocod merged 3 commits intomainfrom
devcrocod/release-workflow-node-setup

Conversation

@devcrocod
Copy link
Copy Markdown
Contributor

@devcrocod devcrocod commented Apr 10, 2026

  • Added setup-node with Node.js 22 to the release workflow — without it, TypeScript integration tests fail because the macOS runner has an incompatible pre-installed Node.js version

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions Release workflow to ensure the release publishing job has a consistent Node.js environment and to streamline the workflow by removing an explicit Gradle build step.

Changes:

  • Adds a actions/setup-node step (Node.js 22) to the release workflow.
  • Removes the standalone ./gradlew build step and relies on publishToMavenCentral for compilation during publishing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/gradle-publish.yml
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copilot AI review requested due to automatic review settings April 13, 2026 11:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +35 to +36
- name: Check
run: ./gradlew check --no-configuration-cache
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description indicate this change is only about adding Node setup, but this workflow also changes the Gradle step from build to check and drops flags like --continue/--rerun-tasks/--max-workers. Please either update the PR description to reflect this behavioral change, or keep the step as build if the intent is to preserve the previous release validation semantics.

Copilot uses AI. Check for mistakes.
@devcrocod devcrocod merged commit c18a488 into main Apr 13, 2026
32 of 33 checks passed
@devcrocod devcrocod deleted the devcrocod/release-workflow-node-setup branch April 13, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants