Document intentional id recovery guard in MessageFactory

valeriudev · valeriudev · commit 262db1a54214 · 2026-06-08T16:00:50.000+03:00
diff --git a/src/JsonRpc/MessageFactory.php b/src/JsonRpc/MessageFactory.php
@@ -111,6 +111,8 @@ public function create(string $input): array
             try {
                 $messages[] = $this->createMessage($message);
             } catch (InvalidInputMessageException $e) {
+                // Recover the id only when it's a valid JSON-RPC scalar;
+                // a null or malformed id is left at the exception's null default.
                 if (\is_array($message) && isset($message['id']) && (\is_string($message['id']) || \is_int($message['id']))) {
                     $e->setRequestId($message['id']);
                 }

Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,8 @@ public function create(string $input): array`
`111`	`111`	`try {`
`112`	`112`	`$messages[] = $this->createMessage($message);`
`113`	`113`	`} catch (InvalidInputMessageException $e) {`
	`114`	`+ // Recover the id only when it's a valid JSON-RPC scalar;`
	`115`	`+ // a null or malformed id is left at the exception's null default.`
`114`	`116`	`if (\is_array($message) && isset($message['id']) && (\is_string($message['id']) \|\| \is_int($message['id']))) {`
`115`	`117`	`$e->setRequestId($message['id']);`
`116`	`118`	`}`