switch to a const default instead of nullable with a check in the function to convert null to a default

Author: johnhunt-lc

src/Capability/Discovery/CachedDiscoverer.php

@@ -41,9 +41,9 @@ public function __construct(
      * @param string             $basePath     the base path for resolving directories
      * @param array<string>      $directories  list of directories (relative to base path) to scan
      * @param array<string>      $excludeDirs  list of directories (relative to base path) to exclude from the scan
-     * @param array<string>|null $namePatterns list of file name patterns for the scan. Compatible with Finder->name()
+     * @param array<string>      $namePatterns list of file name patterns for the scan. Compatible with Finder->name()
      */
-    public function discover(string $basePath, array $directories, array $excludeDirs = [], ?array $namePatterns = ['*.php']): DiscoveryState
+    public function discover(string $basePath, array $directories, array $excludeDirs = [], array $namePatterns = self::DEFAULT_NAME_PATERNS): DiscoveryState
     {
         $cacheKey = $this->generateCacheKey($basePath, $directories, $excludeDirs);
 

src/Capability/Discovery/Discoverer.php

@@ -68,9 +68,9 @@ public function __construct(
      * @param string             $basePath     the base path for resolving directories
      * @param array<string>      $directories  list of directories (relative to base path) to scan
      * @param array<string>      $excludeDirs  list of directories (relative to base path) to exclude from the scan
-     * @param array<string>|null $namePatterns list of file name patterns for the scan. Compatible with Finder->name()
+     * @param array<string>      $namePatterns list of file name patterns for the scan. Compatible with Finder->name()
      */
-    public function discover(string $basePath, array $directories, array $excludeDirs = [], ?array $namePatterns = null): DiscoveryState
+    public function discover(string $basePath, array $directories, array $excludeDirs = [], array $namePatterns = self::DEFAULT_NAME_PATERNS): DiscoveryState
     {
         $startTime = microtime(true);
         $discoveredCount = [
@@ -85,8 +85,6 @@ public function discover(string $basePath, array $directories, array $excludeDir
         $prompts = [];
         $resourceTemplates = [];
 
-        $namePatterns = !empty($namePatterns) ? $namePatterns : ['*.php'];
-
         try {
             $finder = new Finder();
             $absolutePaths = [];

src/Capability/Discovery/DiscovererInterface.php

@@ -20,13 +20,16 @@
  */
 interface DiscovererInterface
 {
+
+public const DEFAULT_NAME_PATERNS = ['*.php'];
+
     /**
      * Discover MCP elements in the specified directories and return the discovery state.
      *
      * @param string             $basePath     the base path for resolving directories
      * @param array<string>      $directories  list of directories (relative to base path) to scan
      * @param array<string>      $excludeDirs  list of directories (relative to base path) to exclude from the scan
-     * @param array<string>|null $namePatterns list of file name patterns for the scan. Compatible with Finder->name()
+     * @param array<string>      $namePatterns list of file name patterns for the scan. Compatible with Finder->name()
      */
-    public function discover(string $basePath, array $directories, array $excludeDirs = [], ?array $namePatterns = null): DiscoveryState;
+    public function discover(string $basePath, array $directories, array $excludeDirs = [], array $namePatterns = self::DEFAULT_NAME_PATERNS): DiscoveryState;
 }

src/Capability/Registry/Loader/DiscoveryLoader.php

@@ -24,14 +24,14 @@ final class DiscoveryLoader implements LoaderInterface
     /**
      * @param string[]       $scanDirs
      * @param array|string[] $excludeDirs
-     * @param string[]|null  $namePatterns
+     * @param string[]       $namePatterns
      */
     public function __construct(
         private string $basePath,
         private array $scanDirs,
         private array $excludeDirs,
         private DiscovererInterface $discoverer,
-        private ?array $namePatterns = null,
+        private array $namePatterns = DiscovererInterface::DEFAULT_NAME_PATERNS,
     ) {
     }
 

src/Server/Builder.php

@@ -353,14 +353,14 @@ public function setSession(
     /**
      * @param string[]      $scanDirs
      * @param string[]      $excludeDirs
-     * @param string[]|null $namePatterns
+     * @param string[]      $namePatterns
      */
     public function setDiscovery(
         string $basePath,
         array $scanDirs = ['.', 'src'],
         array $excludeDirs = [],
         ?CacheInterface $cache = null,
-        ?array $namePatterns = null,
+        array $namePatterns = DiscovererInterface::DEFAULT_NAME_PATERNS,
     ): self {
         $this->discoveryBasePath = $basePath;
         $this->discoveryScanDirs = $scanDirs;