Skip to content

Commit d1c38a1

Browse files
committed
fix tests
1 parent 78aff1e commit d1c38a1

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/Capability/Discovery/SchemaGenerator.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ private function applyEnumConstraints(array $paramSchema, array $paramInfo): arr
374374

375375
if ($jsonBackingType) {
376376
if (isset($paramSchema['type']) && \is_array($paramSchema['type']) && \in_array('null', $paramSchema['type'])) {
377-
$paramSchema['type'] = ['null', $jsonBackingType];
377+
$paramSchema['type'] = [$jsonBackingType, 'null'];
378378
$paramSchema['enum'][] = null;
379379
} else {
380380
$paramSchema['type'] = $jsonBackingType;
@@ -384,7 +384,7 @@ private function applyEnumConstraints(array $paramSchema, array $paramInfo): arr
384384
// Non-backed enum - use names as enum values
385385
$paramSchema['enum'] = array_column($enumClass::cases(), 'name');
386386
if (isset($paramSchema['type']) && \is_array($paramSchema['type']) && \in_array('null', $paramSchema['type'])) {
387-
$paramSchema['type'] = ['null', 'string'];
387+
$paramSchema['type'] = ['string', 'null'];
388388
$paramSchema['enum'][] = null;
389389
} else {
390390
$paramSchema['type'] = 'string';

tests/Unit/Capability/Discovery/SchemaGeneratorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ public function testGeneratesCorrectSchemaForEnumParameters(): void
197197
$this->assertEquals(['type' => 'string', 'description' => 'Backed string enum', 'enum' => ['A', 'B']], $schema['properties']['stringEnum']);
198198
$this->assertEquals(['type' => 'integer', 'description' => 'Backed int enum', 'enum' => [1, 2]], $schema['properties']['intEnum']);
199199
$this->assertEquals(['type' => 'string', 'description' => 'Unit enum', 'enum' => ['Yes', 'No']], $schema['properties']['unitEnum']);
200-
$this->assertEquals(['type' => ['null', 'string'], 'enum' => ['A', 'B'], 'default' => null], $schema['properties']['nullableEnum']);
200+
$this->assertEquals(['type' => ['string', 'null'], 'enum' => ['A', 'B', null], 'default' => null], $schema['properties']['nullableEnum']);
201201
$this->assertEquals(['type' => 'integer', 'enum' => [1, 2], 'default' => 1], $schema['properties']['enumWithDefault']);
202202
$this->assertEqualsCanonicalizing(['stringEnum', 'intEnum', 'unitEnum'], $schema['required']);
203203
}

0 commit comments

Comments
 (0)