Skip to content

feat: allow overriding SSE messages endpoint - #2531

Closed
HenryLee789 wants to merge 1 commit into
modelcontextprotocol:mainfrom
HenryLee789:codex/sse-message-endpoint
Closed

feat: allow overriding SSE messages endpoint#2531
HenryLee789 wants to merge 1 commit into
modelcontextprotocol:mainfrom
HenryLee789:codex/sse-message-endpoint

Conversation

@HenryLee789

@HenryLee789 HenryLee789 commented May 1, 2026

Copy link
Copy Markdown

Summary

  • add an optional messages_url override to sse_client() for reverse-proxy deployments
  • preserve session query parameters from the server endpoint event when an override is used
  • cover absolute and relative overrides plus end-to-end client POST routing

Fixes #2255

Checks

  • uv run pytest tests/shared/test_sse.py -q
  • uv run ruff format --check src/mcp/client/sse.py tests/shared/test_sse.py
  • uv run ruff check src/mcp/client/sse.py tests/shared/test_sse.py
  • uv run pyright src/mcp/client/sse.py tests/shared/test_sse.py
  • uv run coverage combine && uv run coverage report --include='src/mcp/client/sse.py' (100%)
  • git diff --check

@HenryLee789
HenryLee789 force-pushed the codex/sse-message-endpoint branch 2 times, most recently from bbf6277 to 735aa25 Compare May 1, 2026 14:10
@HenryLee789
HenryLee789 force-pushed the codex/sse-message-endpoint branch from 735aa25 to 632ef64 Compare May 1, 2026 14:13
@maxisbey

Copy link
Copy Markdown
Contributor

Thanks for the PR. Per our CONTRIBUTING.md we ask that PRs start from a linked, triaged issue with maintainer buy-in, which this one doesn't have yet. Closing as part of a general backlog cleanup ahead of the v2 release. If this is still relevant against current main, feel free to reopen.

AI Disclaimer

@maxisbey maxisbey closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow explicit message_url override in mcp.client.sse.sse_client

2 participants