Union previously requested scopes on step-up re-authorization (SEP-2350) - #2931
Merged
Claude / Claude Code Review
completed
Jun 20, 2026 in 8m 32s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | tests/client/test_auth.py:1450-1453 |
New test added inside Test* class against repo convention |
Annotations
Check warning on line 1453 in tests/client/test_auth.py
claude / Claude Code Review
New test added inside Test* class against repo convention
Per the repo's AGENTS.md testing convention, new tests should be plain top-level test_* functions, not methods of Test* classes — even when adding to a legacy file that already has them. test_403_step_up_preserves_scope_from_stored_token is added inside the TestAuthFlow class, but the fixtures it uses (oauth_provider, mock_storage) are module-level, so it can be moved to a top-level function unchanged (drop self and dedent), matching the other new test test_union_scopes.
Loading