Skip to content

Drive resolver elicitation over the 2026-07-28 input_required flow - #2986

Merged
maxisbey merged 10 commits into
mainfrom
resolver-input-required
Jun 29, 2026
Merged

Drive resolver elicitation over the 2026-07-28 input_required flow#2986
maxisbey merged 10 commits into
mainfrom
resolver-input-required

Scope the resolver run-once guarantee to questions, not resolver bodies

1a15cb6
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jun 29, 2026 in 27m 54s

Code review found 1 potential issue

Found 4 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit docs/tutorial/dependencies.md:136-138 dependencies.md still claims resolvers run at most once per call alongside the new per-round contract

Annotations

Check warning on line 138 in docs/tutorial/dependencies.md

See this annotation in the file changed.

@claude claude / Claude Code Review

dependencies.md still claims resolvers run at most once per call alongside the new per-round contract

Earlier sections of this page still state the old per-call guarantee — line 61 ("the SDK runs the resolver at most once per call, no matter how many declare it") and line 73 ("it runs **once per call**. One inventory lookup, two consumers") — which now contradicts the per-round contract this PR introduces in the new `!!! info` box and the rewritten Recap bullet on the same page. Reword those earlier statements (and the "Don't take once-per-call on faith" / "*Once per call* means exactly that" ti