Extend the interaction suite to the 2026-07-28 spec - #3018
Open
maxisbey wants to merge 27 commits into
Open
Claude / Claude Code Review
completed
Jul 28, 2026 in 35m 57s
Code review found 4 potential issues
Found 1 candidates, confirmed 4. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 4 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | tests/interaction/README.md:175-179 |
Stale single-era-axis prose contradicts the two-membered SPEC_VERSIONS |
Annotations
Check warning on line 179 in tests/interaction/README.md
claude / Claude Code Review
Stale single-era-axis prose contradicts the two-membered SPEC_VERSIONS
Two doc sentences are stale against the two-membered SPEC_VERSIONS at this PR's head: the README paragraph just below the rewritten TRANSPORT_SPEC_VERSIONS bullet still says "today's test IDs are byte-identical to before the era axis existed" (they are now all [transport-version]-suffixed), and the SpecVersion docstring in tests/interaction/_requirements.py:44-45 still says only one value is on the active axis "until the 2026-07-28 implementation lands" — resolved by this very PR. Both sentences
Loading