Add Cloudflare Pages docs preview with /preview-docs slash command - #3028
Merged
Claude / Claude Code Review
completed
Jun 30, 2026 in 11m 45s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | .github/workflows/docs-preview-cleanup.yml:38-43 |
Cleanup loop aborts on first failed DELETE, leaving remaining deployments undeleted |
Annotations
Check warning on line 43 in .github/workflows/docs-preview-cleanup.yml
claude / Claude Code Review
Cleanup loop aborts on first failed DELETE, leaving remaining deployments undeleted
In the cleanup loop, each `curl -fsS -X DELETE` runs under `set -euo pipefail` with no per-id error tolerance, so a single failed DELETE (transient 5xx, rate limit, or an already-deleted deployment returning 404) aborts the step and skips every remaining id — leaving the rest of the PR's preview deployments stale, which is the leak this workflow exists to prevent. A one-line `|| echo "failed to delete $id"` per id (optionally tracking failures and exiting non-zero at the end) keeps the batch res
Loading