Narrow message_handler's parameter to notifications and exceptions - #3168
Merged
Claude / Claude Code Review
completed
Jul 25, 2026 in 17m 31s
Code review found 3 potential issues
Found 1 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 3 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | docs/migration.md:1654-1656 |
whats-new.md removed-import-paths list omits the newly removed mcp.shared.session |
Annotations
Check warning on line 1656 in docs/migration.md
claude / Claude Code Review
whats-new.md removed-import-paths list omits the newly removed mcp.shared.session
This PR deletes the `mcp.shared.session` module outright (migration.md now says "The `mcp.shared.session` module is gone"), but `docs/whats-new.md`'s "Removed outright" bullet listing removed import paths (line 149) still names only `mcp.types`, `mcp.shared.version`, and `mcp.shared.progress` — so the removal appears nowhere on the v2 overview page. Extend that bullet to include `mcp.shared.session` (with `RequestResponder`), since `from mcp.shared.session import RequestResponder` was the v1-doc
Loading