Fall back to the caller-configured scope when the server advertises none - #3172
Open
maxisbey wants to merge 3 commits into
Open
Fall back to the caller-configured scope when the server advertises none#3172maxisbey wants to merge 3 commits into
maxisbey wants to merge 3 commits into
Claude / Claude Code Review
completed
Jul 27, 2026 in 20m 41s
Code review found 3 potential issues
Found 1 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 3 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | docs/migration.md:1998-2000 |
Empty scopes_supported semantics misdescribed in migration entry and test docstring |
Annotations
Check warning on line 2000 in docs/migration.md
claude / Claude Code Review
Empty scopes_supported semantics misdescribed in migration entry and test docstring
Two prose statements added by this PR misdescribe the empty `scopes_supported=[]` case: the migration bullet claims v1's AS-catalog fallback could be triggered by a resource publishing an *empty* `scopes_supported` (in v1 that fallback only fired when the field was *absent*/`None` — an empty list produced an empty, falsy scope string that was simply omitted), and the new interaction test's docstring in `tests/interaction/auth/test_lifecycle.py` (~lines 407-408) says an empty list "would itself m
Loading