Remove unused mcpserver.exceptions.ValidationError - #3199
Merged
Claude / Claude Code Review
completed
Jul 28, 2026 in 9m 38s
Code review found 1 important issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | src/mcp/server/mcpserver/exceptions.py:5-8 |
Breaking ValidationError removal missing from docs/migration.md |
Annotations
Check failure on line 8 in src/mcp/server/mcpserver/exceptions.py
claude / Claude Code Review
Breaking ValidationError removal missing from docs/migration.md
This PR removes the public symbol `mcp.server.mcpserver.exceptions.ValidationError` — a breaking change per the PR's own checklist — but does not add the required entry to `docs/migration.md` (AGENTS.md: breaking changes *must* be documented there). Add a line to the existing exceptions inventory in the FastMCP→MCPServer section noting `ValidationError` was removed and that callers should catch `pydantic.ValidationError` or drop the import.
Loading