Fixes incorrect casting into int for numbers in string format#384
Merged
Conversation
dsp-ant
approved these changes
Mar 27, 2025
Member
dsp-ant
left a comment
There was a problem hiding this comment.
Thank you! The fix seems to have gotten lost in translation to the official SDK.
dsp-ant
pushed a commit
that referenced
this pull request
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #316
When a parameter in fastMCP is a number, but the type of the tool is string, it is regardless casted into int, and thus the tool fails. This issue was solved in the original FastMCP repo but apparently it was lost. I just added the code back as suggested together with its test.
Original fix
Current Issue report:
Motivation and Context
Fixes tool input numbers being cast into
intwhen they are specified asstr.How Has This Been Tested?
I added back the original test. It matches the errors I'm seeing when using FastMCP 1.5.0 in my project.
Breaking Changes
No
Types of changes
Checklist
Additional context