Improved docs for better clarity on mounting ASGI apps#873
Closed
ayush0x00 wants to merge 2 commits into
Closed
Conversation
felixweinberger
requested changes
Jul 17, 2025
felixweinberger
left a comment
Contributor
There was a problem hiding this comment.
Hi @ayush0x00, thank you for your contribution! Apologies for the time it took to get to this review.
The existing docs just below already show this pattern sufficiently and comprehensively (see search_mcp example on lines ~530-550) so this would add some duplicated information. Also the code block should be using backticks with a python annotation.
Could you elaborate what in the docs isn't clear in your perspective to warrant this duplication?
Contributor
|
Hi @@ayush0x00, thanks again for your contribution. I'm closing this PR for now - as explained I think the existing documentation already covers this pattern sufficiently. Please feel free to reopen or resubmit a PR if you disagree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added clarification on the documentation
Motivation and Context
This elaboration is required so that users can effectively mount on different paths concerning their ASGI application
How Has This Been Tested?
No test is required. Just a documentation update. This feature was already present in the code.
Breaking Changes
No
Types of changes
Checklist
Additional context
Fixes #872