fix: remove unnecessary fields from tools' inputSchema#856
Open
fpoli wants to merge 1 commit into
Open
Conversation
inputSchemainputSchema
alexhancock
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the
inputSchemageneration of MCP tools, removing the unnecessary top-level fields mentioned in #847.In more detail, the PR adds a
schema_for_inputwrapper aroundschema_for_type. The wrapper prepares theinputSchemaof macro-generated tool descriptions, removing the top-leveltitleanddescriptionfields (i.e. the type name and doc ofTinParameters<T>).Motivation and Context
See #847. To sum up, I think the top-level
titleanddescriptionfields are unnecessary:TinParameters<T>) that should not be leaked to the LLM. See these examples. What matters is the type and docs of the fields ofT, which remain in theinputSchemaand are not modified by this PR.How Has This Been Tested?
By adding a
test_list_tools_result.rs, which compares the tool description against a reference description in a JSON file.(No) Breaking Changes
The top-level
titleanddescriptiondisappear from theinputSchema. This is not a breaking change because the fields are not part of the MCP specification.Types of changes
Checklist
Additional context
Fixes #847.