fix(everything): require key parameter for get-env tool to prevent env leakage#4011
Closed
Will-hxw wants to merge 4 commits intomodelcontextprotocol:mainfrom
Closed
fix(everything): require key parameter for get-env tool to prevent env leakage#4011Will-hxw wants to merge 4 commits intomodelcontextprotocol:mainfrom
Will-hxw wants to merge 4 commits intomodelcontextprotocol:mainfrom
Conversation
Prevent leaking all process.env variables by requiring a specific key. This addresses a security concern where the tool was returning the entire environment without any parameter or filtering. Issue: #3986 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The get-env tool was failing TypeScript strict mode checks because the inputSchema was declared as a plain object with 'type: string' instead of a Zod schema. This causes the type checker to reject the argument. Fixes TypeScript errors: - TS2345: inputSchema type not assignable to parameter type - TS7006: Parameter 'args' implicitly has an 'any' type
The get-env tool now requires a 'key' parameter. Updated tests to
pass { key: 'TEST_VAR_EVERYTHING' } and { key: 'PATH' } instead
of empty object {}.
The get-env tool returns 'KEY=value' format, not JSON. Updated assertions accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Issue #3986: get-env tool returns the entire process.env object without any parameters, potentially leaking all environment variables including API keys and tokens.
Validation