Use monotonic integer IDs for ID.random by default#259
Open
JamieScanlon wants to merge 1 commit into
Open
Conversation
UUID string request IDs are JSON-RPC valid but cause Apple mcpbridge to hang silently. Default to monotonic .number IDs for broader server compatibility; keep UUID generation via ID.randomUUID. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ID.randomto allocate monotonic JSON integer ids (.number) instead of UUID strings.ID.randomUUID.idvalues.Motivation
Apple's
xcrun mcpbridge(Xcode) never responds to JSON-RPC requests whoseidis a string, null, or float — it only answers integer ids. With the current UUID-string default, clients built on this SDK hang forever oninitializewhen talking tomcpbridge, while ad-hoc clients that use integer ids work.String/UUID ids are legal per JSON-RPC 2.0;
mcpbridgeis non-compliant. Defaulting to integers preserves legality and maximizes real-world server compatibility.Test plan
ID.randomyields unique.numbervalues; encoding produces a bare JSON numberID.randomUUIDstill yields UUID stringsxcrun mcpbridge;initializecompletes;tools/listreturns toolsMade with Cursor